-
Notifications
You must be signed in to change notification settings - Fork 153
Current state of 1.1 development #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- be more verbose in some error messages - add some more comments pointing to the specs - add a blank node condition according to spec 16.4
Focusing on expansion and context/term processing
|
I just discovered that there is a new Java implementation for JSON-LD 1.1, titanium-json-ld: https://github.com/filip26/titanium-json-ld. It is linked from https://json-ld.org/ and included in the conformance report at https://w3c.github.io/json-ld-api/reports/. Given the amount of work still required here, and the level of conformance already achieved by titanium-json-ld, I'm wondering if it actually makes sense to continue our effort here. |
|
I have not had time to put into this project recently. If the JSON-LD 1.1 changes are not progressing well, then that may be an option. I am merging this into the 1.1 branch based on Travis passing. |
|
I did some benchmarks of both implementations and Json-LD Java is by far more performant. As I mentioned on the repo it is very well just probably due to the fact that the Json-LD 1.1 spec is more complex and not to the titanium codebase. However it is good to keep track of it |
Depending on which algorithms are involved, for 1.0-like data, the added complexity shouldn't really impact performance. There are some additional checks to look for scoped contexts in expansion and compaction, and for different container types, but I wouldn't expect these to have any significant affect on basic performance if these features aren't used. A healthy eco-system depends on diverse implementations, and I hope that jsonld-java continues to make progress towards full 1.1 conformance. |
As announced in #277 (comment), this PR contains the current functional changes for 1.1.
It also contains comments by @gkellogg from gkellogg@53aa216 (thanks!)
The diff on
core/reports/json-ld-api-tests-skipshows the progress compared to the1.1-testsbranch (currently 94 removed lines, i.e. 94 additional passing tests). See individual commits for details on which code changes make which tests pass. Open the URLs for test details.This is the report summary for 1.1 compliance with the current code (see 2318376):
The base for this PR is set to
1.1-testsfor a reviewable diff (i.e. merge into master after #283).