Skip to content

Throw error on empty key in context#251

Merged
ansell merged 1 commit intojsonld-java:masterfrom
fsteeg:141-errorOnEmptyKey
Feb 23, 2019
Merged

Throw error on empty key in context#251
ansell merged 1 commit intojsonld-java:masterfrom
fsteeg:141-errorOnEmptyKey

Conversation

@fsteeg
Copy link
Copy Markdown
Member

@fsteeg fsteeg commented Feb 14, 2019

I think with this we can resolve #141.

The actual issue of producing invalid output from Jena has been fixed in Jena as described by @afs in #141 (comment). This pull request adds throwing an error as mentioned by @ansell in #141 (comment).

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 89.027% when pulling f406471 on fsteeg:141-errorOnEmptyKey into 47eaff4 on jsonld-java:master.

@fsteeg
Copy link
Copy Markdown
Member Author

fsteeg commented Feb 22, 2019

@ansell @tristan, how do you feel about merging this? Let me know if you have any doubts.

In general, should I assign you (one of you? both?) when I open a pull request? And should I rather push to branches in this repo (not my fork) so that you can push changes into proposed pull requests?

@ansell
Copy link
Copy Markdown
Member

ansell commented Feb 23, 2019

If we need to make changes, we can pull locally and merge. Sorry I haven't had a chance to look at this so far. It looks good to me.

@ansell ansell merged commit a1075bd into jsonld-java:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid JSON-LD if Jena defines an "" prefix

3 participants