fix: #2146 ES6 class mixin static members incorrectly converted to instance scope #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix parser.js to check node.static for class properties - Add test case to verify static properties are parsed correctly - Static properties now use correct longname (ClassName.prop) and scope (static) - Fix prettier formatting issues in parser.js and test files - All tests pass, confirming the fix doesn't break existing functionality - Fixes issue jsdoc#2144
…scope - Fix staticToInstance function in augment.js to preserve ES6 class static members - Add comprehensive test cases for both ES6 class mixins and traditional object mixins - ES6 class static members defined with 'static' keyword now remain static when mixed - Traditional object mixin members continue to be converted to instance (unchanged behavior) - Backward compatible: no breaking changes for existing codebases Fixes: ES6 class mixin static members incorrectly converted to instance scope during augmentation Related: Depends on fix for issue jsdoc#2144 (static property scope detection in parser) Test coverage: - ES6 class static properties/methods with 'static' keyword → remain static - ES6 class properties/methods defined outside class → become instance - Traditional object mixin properties/methods → become instance (unchanged) - All existing functionality continues to work without regression
Haixing-Hu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ES6 class mixin static members incorrectly converted to instance scope
Test coverage:
Related: Depends on fix for issue #2144 (static property scope detection in parser)