Deal with HTML paragraphs, without an ending period #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is pretty common for the markdown plugin to generate description where the first line is wrapped in <p>. There is already an existing line to deal with and remove these <p> explicitely. This was however not working when the first line didn't end with a . The split caused `<p>summary</p>.` combinations because we force added a . after the non-matching split. This combination then subsequently did not match the <p> stripping regex at the end. By force splitting on end of line we can avoid this mistake.
|
@hegemonic This PR has been open for some time, could you (or someone) review it please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is pretty common for the markdown plugin to generate description where the first line is wrapped in
<p>. There is already an existing line to deal with and remove these<p>explicitely.This was however not working when the first line didn't end with a . The split caused
<p>summary</p>.combinations because we force added a . after the non-matching split. This combination then subsequently did not match the<p>stripping regex at the end.By force splitting on end of line we can avoid this mistake.