fix(README): phrase the note abouth webpack v2 in a slightly better way#145
Merged
kentcdodds merged 1 commit intojs-dxtools:masterfrom Dec 2, 2016
Merged
fix(README): phrase the note abouth webpack v2 in a slightly better way#145kentcdodds merged 1 commit intojs-dxtools:masterfrom
kentcdodds merged 1 commit intojs-dxtools:masterfrom
Conversation
Current coverage is 100% (diff: 100%)@@ master #145 diff @@
====================================
Files 18 18
Lines 151 151
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 151 151
Misses 0 0
Partials 0 0
|
kentcdodds
requested changes
Dec 2, 2016
Collaborator
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
I almost want to add something to the effect of:
Due to this, `webpack-validator` is unlikely to make significant changes. While pull requests will be reviewed and can be merged, project maintainers are unlikely to put a lot of much effort into the maintenance of the project.
At least, that's how I feel at this point. Anyone else?
| You're very welcome to give [feedback](https://github.com/js-dxtools/webpack-validator/issues) & [PR's](https://github.com/js-dxtools/webpack-validator). | ||
|
|
||
| **Note that as of webpack v2 (currently in beta), configuration validation is baked in.** | ||
| **Note: webpack v2 has built-in validation for configuration.** |
Collaborator
There was a problem hiding this comment.
Could this be even more clear like this:
**Note: webpack v2 has built-in validation for configuration. So please don't attempt to use this package with webpack 2.**
Collaborator
|
@kentcdodds Good addition! |
Collaborator
|
Merging this, I'll open a PR for the extra wording. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for Webpack Validator!
This is a little follow-up for the #144