With SQL, local keys for optional relations will most likely be nullable, which results in the query:

SELECT * FROM table WHERE id = ''

Also, the falsey check is already being used for the other relation types, just not belongsTo. Which is why only optional belongsTo relations cause unnecessary queries and Not Found! errors to be thrown.

I missed handling the other half of the belongsTo logic, resulting in queries like:

SELECT * FROM table WHERE 1 = 0

Now these should be discarded without querying.

Edit: These queries were being made by the adapter before my changes, not because of them. This is probably knex translating WHERE id IN () to the equivalent and not invalid WHERE 1 = 0

Can you squash into one commit?

Give me a minute

Struggling with GitHub Desktop...

#53