Skip to content

Only acquire the blocking lock if blocking - #9905

Draft
headius wants to merge 2 commits into
jruby:masterfrom
headius:reduce_blocking_lock
Draft

headius wants to merge 2 commits into
jruby:masterfrom
headius:reduce_blocking_lock

Conversation

@headius

@headius headius commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

In #9886 a user reported that because of our locking of a selectable channels blockingLock while calling select, any blocking operation against that channel would prevent other operations from happening. In the case of a socket, which can both read and write concurrently, this limits functionality.

The base problem is our need to set a blocking socket to nonblocking for the duration of the select and then safely restore
it to blocking afterwards. If the socket were always nonblocking, no lock would need to be acquired because the blocking state would not need to be changed.

The PR in #7466 makes an attempt to mark selectable channels as nonblocking at create time, matching CRuby 3.0 behavior and opening up the possibility of avoiding the lock. That is implemented in this patch, which only acquires the lock if the blocking state needs to be reconfigured.

This appears to fix the example from #9886. It depends upon the nonblocking changes in #7466.

Ruby 3.0 began to set O_NONBLOCK by default for all IO, to allow more IO
types to enlist in the new IO/fiber scheduling. JRuby has not previously
defaulted to nonblock, but all IO operations against nonblock-compatible
channels does use nonblocking semantics, so all we really need to align
with CRuby is to just set them non-blocking at the NIO level on
creation.

We can only do this when the underlying channel supports
nonblocking semantics, but this commit attempts to set such
channels up properly.

Part of scheduler work in jruby#7459 and related issues.
In jruby#9886 a user reported that because of our locking
of a selectable channels blockingLock while calling select, any
blocking operation against that channel would prevent other
operations from happening. In the case of a socket, which can both
read and write concurrently, this limits functionality.

The base problem is our need to set a blocking socket to
nonblocking for the duration of the select and then safely restore
it to blocking afterwards. If the socket were always nonblocking,
no lock would need to be acquired because the blocking state would
not need to be changed.

The PR in jruby#7466 makes an attempt to mark selectable
channels as nonblocking at create time, matching CRuby 3.0
behavior and opening up the possibility of avoiding the lock. That
is implemented in this patch, which only acquires the lock if the
blocking state needs to be reconfigured.

This appears to fix the example from jruby#9886. It depends
upon the nonblocking changes in jruby#7466.
@headius
headius force-pushed the reduce_blocking_lock branch from efe6bb0 to b661014 Compare October 27, 2026 22:41
@sampokuokkanen

Copy link
Copy Markdown
Contributor

With sockets and pipes nonblocking by default, this can go away:

// Can go away once our sockets and pipes default to nonblocking.
private static int schedulerRead(ThreadContext context, OpenFile fptr,
ByteBuffer buffer, int buf, int count) {
try {
fptr.setNonblock(context.runtime);
while (true) {
int read = executeRead(context, fptr, buffer, buf, count);
if (read >= 0 || !fptr.waitReadable(context)) return read;
}
} finally {
if (fptr.isOpen()) fptr.setBlock(context.runtime);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants