Repository navigation
Conversation
Ruby 3.0 began to set O_NONBLOCK by default for all IO, to allow more IO types to enlist in the new IO/fiber scheduling. JRuby has not previously defaulted to nonblock, but all IO operations against nonblock-compatible channels does use nonblocking semantics, so all we really need to align with CRuby is to just set them non-blocking at the NIO level on creation. We can only do this when the underlying channel supports nonblocking semantics, but this commit attempts to set such channels up properly. Part of scheduler work in jruby#7459 and related issues.
In jruby#9886 a user reported that because of our locking of a selectable channels blockingLock while calling select, any blocking operation against that channel would prevent other operations from happening. In the case of a socket, which can both read and write concurrently, this limits functionality. The base problem is our need to set a blocking socket to nonblocking for the duration of the select and then safely restore it to blocking afterwards. If the socket were always nonblocking, no lock would need to be acquired because the blocking state would not need to be changed. The PR in jruby#7466 makes an attempt to mark selectable channels as nonblocking at create time, matching CRuby 3.0 behavior and opening up the possibility of avoiding the lock. That is implemented in this patch, which only acquires the lock if the blocking state needs to be reconfigured. This appears to fix the example from jruby#9886. It depends upon the nonblocking changes in jruby#7466.
headius
force-pushed
the
reduce_blocking_lock
branch
from
October 27, 2026 22:41
efe6bb0 to
b661014
Compare
Contributor
|
With sockets and pipes nonblocking by default, this can go away: jruby/core/src/main/java/org/jruby/util/io/OpenFile.java Lines 1610 to 1624 in b661014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9886 a user reported that because of our locking of a selectable channels blockingLock while calling select, any blocking operation against that channel would prevent other operations from happening. In the case of a socket, which can both read and write concurrently, this limits functionality.
The base problem is our need to set a blocking socket to nonblocking for the duration of the select and then safely restore
it to blocking afterwards. If the socket were always nonblocking, no lock would need to be acquired because the blocking state would not need to be changed.
The PR in #7466 makes an attempt to mark selectable channels as nonblocking at create time, matching CRuby 3.0 behavior and opening up the possibility of avoiding the lock. That is implemented in this patch, which only acquires the lock if the blocking state needs to be reconfigured.
This appears to fix the example from #9886. It depends upon the nonblocking changes in #7466.