Repository navigation
Move the repeated CI bootstrap steps into a composite action - #9866
Merged
Merged
Conversation
Nearly every CI job repeated the same block: remove the preinstalled JDKs, set up Java with the Maven cache, build with -Pbootstrap, and bundle install. The copies had drifted: some jobs skipped ci-retry.sh, and the Prism WASM job still used checkout@v3, setup-java@v3 and a system mvn instead of the wrapper. .github/actions/bootstrap now holds those steps, with inputs for the places where jobs really differ (Java version and distribution, whether to remove the old JDKs, the Maven arguments, bundle install flags). The dist build jobs use it with -Pall. Linux and macOS builds all go through ci-retry.sh now, which only retries network failures. Windows keeps running the wrapper directly from PowerShell, since ci-retry.sh needs bash. Also share the Windows env block with a YAML anchor and drop the duplicate rake-test from publish-snapshot's needs.
headius
approved these changes
Oct 21, 2026
headius
left a comment
Member
There was a problem hiding this comment.
Good cleanup. Always meant to do this but never got around to it.
Member
|
This will make merging any CI changes from 10.0 pretty much impossible, but we aren't making many changes there anyway. If at some time we need to make changes we can backport this cleanup. |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nearly every CI job repeated the same block: remove the preinstalled JDKs, set up Java with the Maven cache, build with -Pbootstrap, and bundle install. The copies had drifted: some jobs skipped ci-retry.sh, and the Prism WASM job still used checkout@v3, setup-java@v3 and a system mvn instead of the wrapper.
.github/actions/bootstrap now holds those steps, with inputs for the places where jobs really differ (Java version and distribution, whether to remove the old JDKs, the Maven arguments, bundle install flags). The dist build jobs use it with -Pall.
Linux and macOS builds all go through ci-retry.sh now, which only retries network failures. Windows keeps running the wrapper directly from PowerShell, since ci-retry.sh needs bash.
Also share the Windows env block with a YAML anchor and drop the duplicate rake-test from publish-snapshot's needs.