[10.0] build: improve build/maven consistency / bump github actions#9317
Merged
headius merged 7 commits intojruby:jruby-10.0from Mar 28, 2026
Merged
Conversation
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
It's not great practice to be mix+matching mvn and mvnw; since it risks inconsistency. When Maven 4 comes out this practice will cause headaches :-) Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Don't think it's necessary to lock these independently; they can probably just use the version implied by the source control version. Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
chadlwilson
commented
Mar 18, 2026
chadlwilson
commented
Mar 18, 2026
chadlwilson
commented
Mar 18, 2026
headius
approved these changes
Mar 28, 2026
Member
headius
left a comment
There was a problem hiding this comment.
Looks good. I must admit I find the ./mvnw everywhere to be a bit verbose but the consistent build behavior is worth it.
Member
|
An exercise for another time would be to further reduce duplication between these jobs. Most of these jobs have only a few lines of difference. |
Contributor
Author
Yeah, I'm in two minds myself about the value of the wrappers (and needing to upgrade them) however having two approaches undermines it. So seems better to me to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the build process for improved consistency:
Build
./mvnweverywhere, rather than mix-and-matching "maven version installed on github actions default runner" with "maven version implied by wrapper" and "maven version I have installed locally"--no-transfer-progress/-ntpconsistently rather than mixing with--batch-mode/-Bin some places.GitHub Actions
strategywithoutmatrixpublish-snapshots.ymlworkflow to run with the version implied by the repo and branch/revision the actions are running on rather than locking to somejruby/jrubyrevisionjavaLevel- each branch can define its targets/matrix independently in its workflows.master).