More arg-handling improvements for Enumerables#928
Merged
enebo merged 1 commit intojruby:masterfrom Aug 28, 2013
Merged
Conversation
Make Enumerable#all, #none, #one, and #find_index behave to spec in the case of #each yielding multiple values (also remove zip_tags.txt while we're in there since it's passing)
enebo
added a commit
that referenced
this pull request
Aug 28, 2013
More arg-handling improvements for Enumerables
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the first follow-up (of probably a few) to #898, getting things even closer to full compatibility for
Enumerable.This makes
Enumerable#all,#none,#one, and#find_indexbehave tospec in the case of
#eachyielding multiple values (also untags#zip_tagssince it's passing).Note that this fix smells a touch too localized at the moment (what's so special about
CallBlock'syieldthat we prep the args there? Isn't it likely that there's other places that need the same treatment?), but as I fix the rest of the Enumerable arg issues, I'm hoping that a good, holistic approach will reveal itself.(Side note: I see Travis is red at the moment, but you can see a clean run on this branch here)