Fix BigDecimal#+, #-, #add, #sub failing when coercing doesn't return a BigDecimal#9204
Merged
headius merged 2 commits intojruby:masterfrom Jan 30, 2026
Merged
Conversation
headius
reviewed
Jan 30, 2026
core/src/main/java/org/jruby/ext/bigdecimal/RubyBigDecimal.java
Outdated
Show resolved
Hide resolved
headius
reviewed
Jan 30, 2026
core/src/main/java/org/jruby/ext/bigdecimal/RubyBigDecimal.java
Outdated
Show resolved
Hide resolved
instanceof will not return true for null.
headius
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9194
For some reason, only in cases of addition and subtraction precision gets assigned to result. Probably, this is why only in these two methods there was a cast. Now, there is a test for type of result in both cases. Also for
null, as subtraction didn't check for that. Addition and subtraction with tricky types works now:mult()has this:So it seems that precision may be lost or ignored in most operations. This PR does not address any of that.