Conversation
JRuby was overzealous in duping kwargs hashes, losing the ruby2_keywords_hash bit in the process. This backs off duping and only does so if receiving ruby2 kwargs for a modern kwargs method. See jruby#8976
Member
|
Aces. Thanks for the help on this one! |
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively fixes mocha by noticing a splatted list with a ruby2keywordhash being passed into a ruby2keyword method. So it dups and strips the ruby2keyword hash state. The other half of this was to not dup blindly in a couple of code paths if it is a ruby2keywordhash.