Fix Data subclasses with ivars#9181
Merged
headius merged 2 commits intojruby:ruby-4.0from Feb 3, 2026
Merged
Conversation
Data subclasses were set up to copy their parent class's var table manager and accessors, but did not overwrite those copies' realClass to the new class. This resulted in future variable accesses potentially walking back to the parent class, seeing an incorrect var table size, and allocating the wrong size table for the spilled instance variables. The new logic does that copying with the new realClass in hand and properly replaces it in the copied accesses and manager. This fixes all remaining issues marshaling Data with Psych and may fix other issues with Data subclasses that are not currently showing up in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data subclasses were set up to copy their parent class's var table manager and accessors, but did not overwrite those copies' realClass to the new class. This resulted in future variable accesses potentially walking back to the parent class, seeing an incorrect var table size, and allocating the wrong size table for the spilled instance variables.
The new logic does that copying with the new realClass in hand and properly replaces it in the copied accesses and manager.
This fixes all remaining issues marshaling Data with Psych and may fix other issues with Data subclasses that are not currently showing up in tests.