Don't dup ruby2 kwargs for non-kwargs method#9151
Closed
headius wants to merge 2 commits intojruby:masterfrom
Closed
Don't dup ruby2 kwargs for non-kwargs method#9151headius wants to merge 2 commits intojruby:masterfrom
headius wants to merge 2 commits intojruby:masterfrom
Conversation
JRuby was overzealous in duping kwargs hashes, losing the ruby2_keywords_hash bit in the process. This backs off duping and only does so if receiving ruby2 kwargs for a modern kwargs method. See jruby#8976
Member
Author
|
Closing this in favor of #9192 which fixes the issue without regressing. I'll do a separate PR for a large refactoring of this logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8976.