Prevent modifying state in RubyProc#9112
Merged
headius merged 4 commits intojruby:masterfrom Dec 4, 2025
Merged
Conversation
A change during 9.4.x accidentally modified this code to update the "file" field on RubyProc, rather than using a local variable. This restores that local variable and subsequent commits will make the fields final to avoid this happening in the future. Fixes jruby#9110
headius
changed the title
headius
changed the title
No reason they wasn't final before; they're only initialized in the constructor.
There was no reason this was not final other than having a lot of noisy logic to set up the block before storing it. I reworked how that setup happens and the field is now final. This is not in any way endorsing that setup as being correct.
fromMethod was only assigned in two places that were easily incorporated into construction. Constructors have been modified to only assign finals in one place and to elminate some paths that have been deprecated for over a decade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change during 9.4.x accidentally modified this code to update the "file" field on RubyProc, rather than using a local variable. This restores that local variable and subsequent commits will make the fields final to avoid this happening in the future.
Fixes #9110