Merged
Conversation
This also opens up the possibility of using a BigInteger in the future, if overflow becomes a problem.
This may eventually avoid the roundtrip through runtime, so use it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of small improvements for
object_id, inspired by Ruby 4.0 object_id optimizations and with an eye for future removal of_id2ref.Ideas to try:
Use long rather than IRubyObject in MRIRecursionGuard.(rejected as this is unused, deprecated code and the replacement does not useobject_id)Cache RubyInteger version after access, to avoid constructing it repeatedly.(rejected for now; storing RubyFixnum would negate size optimizations above and an alternative box requires more thought)