Reserve extra space before elements when unshifting#9059
Merged
headius merged 1 commit intojruby:masterfrom Nov 10, 2025
Merged
Reserve extra space before elements when unshifting#9059headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
This change expands the array for an unshift by sliding elements forward, leaving additional space for future unshifts to proceed without copying or reallocating. When expanding, the existing elements are moved to the end of the native array. This assumes that if one value is unshifted, future values are also likely to be unshifted rather than pushed at the end. This could reduce performance if values are being both unshifted (at begin) and pushed (at end), but the trade-off to have the more common case of all unshifts seems worth it. Fixes jruby#9058
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change expands the array for an unshift by sliding elements forward, leaving additional space for future unshifts to proceed without copying or reallocating. When expanding, the existing elements are moved to the end of the native array.
This assumes that if one value is unshifted, future values are also likely to be unshifted rather than pushed at the end. This could reduce performance if values are being both unshifted (at begin) and pushed (at end), but the trade-off to have the more common case of all unshifts seems worth it.
Fixes #9058