Skip to content

Migrate .java-version contents to .jruby.release#9041

Merged
headius merged 1 commit intojruby:masterfrom
headius:min_java_version_in_release_file
Nov 3, 2025
Merged

Migrate .java-version contents to .jruby.release#9041
headius merged 1 commit intojruby:masterfrom
headius:min_java_version_in_release_file

Conversation

@headius
Copy link
Member

@headius headius commented Oct 24, 2025

I think it makes more sense to use .jruby.release as the only file for version-specific details. This change may need to be tweaked to support JRuby 10 releases prior to 10.0.3.0 (assuming it is merged into that release), or it may not be important since we won't be changing the jruby.sh in any released artifacts.

@headius headius added this to the JRuby 10.0.3.0 milestone Oct 24, 2025
@headius
Copy link
Member Author

headius commented Oct 24, 2025

@enebo @mrnoname1000 I've been doing some cleanup and realized we don't really need both .jruby.release and .java-version in bin. I think it makes sense to lean into the use of .jruby.release as the store of all version-specific values, since we already have it in place for the JRuby version and the main class to use.

I had some initial concerns about making this change, since it will not work properly if copied into older 10.x releases that have a .java-version file, but perhaps I'm worrying about nothing? We won't be replacing the jruby.sh in those releases now that they're out, and we don't support installing updated jruby.sh from jruby-launcher yet.

Of course, if jruby-launcher does gain the ability to update jruby.sh, then we will want to make sure it doesn't break on old releases. Cross that bridge when we come to it?

I think it makes more sense to use .jruby.release as the only file
for version-specific details. This change may need to be tweaked
to support JRuby 10 releases prior to 10.0.3.0 (assuming it is
merged into that release), or it may not be important since we
won't be changing the jruby.sh in any released artifacts.
@headius headius force-pushed the min_java_version_in_release_file branch from 9056e03 to d448007 Compare November 3, 2025 16:11
@headius headius merged commit b05098a into jruby:master Nov 3, 2025
73 of 74 checks passed
@headius headius deleted the min_java_version_in_release_file branch November 3, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant