More arg handling fixes for Enumerable methods#898
Closed
dmarcotte wants to merge 1 commit intojruby:masterfrom
Closed
More arg handling fixes for Enumerable methods#898dmarcotte wants to merge 1 commit intojruby:masterfrom
dmarcotte wants to merge 1 commit intojruby:masterfrom
Conversation
Contributor
Author
|
Opened #901 for the remaining enumerable issues and noticed that there's Rubyspec tags for the yield issue. |
Member
|
Merged in 7723b9a. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #836, I reviewed Enumerable's methods for other places the fix in #807 should be extended to. There were quite a few :)
This fixes almost all of them, focusing on the ones which could be remedied by proper arg packing and/or an arity tweak. Here's what's still outstanding:
#chunk,#slice_before, and#take_whilestill misbehave but seem to require deeper fixes#eachis implemented with ablock.call,yieldfails a couple the tests added here (for the methods likeany?that don't want the args packed into an array)I'll open separate issues to track those and ideally follow up with fixes.