Upgrade polyglot and remove openssl lib hack#8963
Merged
headius merged 1 commit intojruby:jruby-9.4from Aug 15, 2025
Merged
Conversation
The lib hack here put a blank openssl.rb into lib/target/lib and added that directory to the LOAD_PATH of the polyglot JRuby runtime. This was done many years ago, perhaps before we had refined how standard libraries could be loaded from released JRuby stdlib jars, and does not appear to be necessary now for a successful build. In jruby#8634 we learned that because newer RubyGems depends on OpenSSL at runtime, and we're feeding it a bogus openssl.rb, newer polyglot versions that depends on newer JRuby versions cannot successfully build JRuby from repo. This PR removes the openssl.rb lib hack altogether and does not appear to break local builds of JRuby while allowing polyglot to be upgraded to latest. Fixes jruby#8634
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lib hack here put a blank openssl.rb into lib/target/lib and added that directory to the LOAD_PATH of the polyglot JRuby runtime. This was done many years ago, perhaps before we had refined how standard libraries could be loaded from released JRuby stdlib jars, and does not appear to be necessary now for a successful build. In #8634 we learned that because newer RubyGems depends on OpenSSL at runtime, and we're feeding it a bogus openssl.rb, newer polyglot versions that depends on newer JRuby versions cannot successfully build JRuby from repo.
This PR removes the openssl.rb lib hack altogether and does not appear to break local builds of JRuby while allowing polyglot to be upgraded to latest.
Fixes #8634
Backport of #8962 to 9.4.