Fixes #8948. SassC - array size too big#8950
Merged
enebo merged 1 commit intojruby:masterfrom Aug 7, 2025
Merged
Conversation
At some point during JRuby 10 we decided to pre-alloc get_array_of_string. Later JRuby API changes made it appear like those new APIs caused this but it was pre-alloc. The problem is sassc (or FFI) decides to ask for an array or strings and the size of the memory alloced is MAX_LONG (big question on why unrelated to this issue). get_array_of_strings has an if check for null memory and immediately exits the fill loop and basically makes a zero length array. By pre-allocing we basically do not ever see that this is a small array. I reverted to using an empty array like 9.4 still does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point during JRuby 10 we decided to pre-alloc get_array_of_string. Later JRuby API changes made it appear like those new APIs caused this but it was pre-alloc.
The problem is sassc (or FFI) decides to ask for an array or strings and the size of the memory alloced is MAX_LONG (big question on why unrelated to this issue). get_array_of_strings has an if check for null memory and immediately exits the fill loop and basically makes a zero length array. By pre-allocing we basically do not ever see that this is a small array.
I reverted to using an empty array like 9.4 still does.