New check for System.console tty on JDK 22+#8947
Merged
headius merged 2 commits intojruby:masterfrom Aug 12, 2025
Merged
Conversation
Member
Author
|
I added a very basic test that confirms a backtick subprocess does not default to using color. I'm not sure how to guarantee a test for a real TTY will trigger color... probably needs some pty magic I don't know. We'll go with the simple negative test for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new
isTerminalmethod when running on JDK 22+ due to that version now always returning a non-nullConsolefromSystem.console().I may modify the handling of these color-configuring properties such that "true" means "use color if we are outputting to a terminal", defaulting to true.
Fixes #8934.