Don't include Object for pathed constant searches#8912
Merged
headius merged 2 commits intojruby:jruby-9.4from Jul 12, 2025
Merged
Don't include Object for pathed constant searches#8912headius merged 2 commits intojruby:jruby-9.4from
headius merged 2 commits intojruby:jruby-9.4from
Conversation
headius
force-pushed
the
const_defined_no_object
branch
5 times, most recently
from
5128229 to
c636075
Compare
The change here is form-fit to this specific case, but basically, we never search Object as an inherited namespace for const_defined? and if we are doing a namespaced lookup don't do the extra search against Object either. Other paths like const_get should continue to search Object to fit the spec. Fixes jruby#8867
headius
force-pushed
the
const_defined_no_object
branch
from
c636075 to
cb9143c
Compare
headius
changed the title
Member
Author
|
I did this fix against 9.4 but it will be released in 10.0.1.0 first. Stupid github still doesn't allow multiple milestones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix here is a little bit form-fitting but largely avoids inheriting constants from Object when doing String-based constant lookups and skips the additional search of Object if we are doing a path search.