Fix an additional dstring indy optimization long bitfield bug#8896
Merged
headius merged 2 commits intojruby:masterfrom Jul 7, 2025
Merged
Fix an additional dstring indy optimization long bitfield bug#8896headius merged 2 commits intojruby:masterfrom
headius merged 2 commits intojruby:masterfrom
Conversation
This went unfixed during the original long bitfield fixes in 4b897ee and was not noticed until I started playing with the hexapdf benchmarks again in jruby#8824. This only breaks when the total number of elements (strings and dynamic objects) exceeds 31, since the integer shift will then produce zero and stop setting higher bits. It also does not happen for dstr with more than 50 elements, the limit of the current optimization.
See some discussion in jruby#8824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.