Handle simple transcoding replacement correctly#8873
Merged
headius merged 4 commits intojruby:masterfrom Jun 20, 2025
Merged
Conversation
Bug while porting from CRuby. Fixes jruby#8872
headius
force-pushed
the
encode_with_replace
branch
from
8245bbc to
a0e3f74
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes here improve the handling of different
String#encodearities, specifically fixing the simple replacement issue reported in #8872 but also reducing the duplicated work along the different arity paths.Fixes #8872.