Always remove the lock from pool on failure#8871
Merged
headius merged 1 commit intojruby:masterfrom Jun 20, 2025
Merged
Conversation
Leaving this here after a failed require means other threads will assume the require is in progress and not attempt their own. Fixes the remaining issue breaking Zeitwerk in jruby#8863.
headius
force-pushed
the
sticky_require_state
branch
from
b4207ab to
c5a21b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving this here after a failed require means other threads will assume the require is in progress and not attempt their own.
Fixes the remaining issue breaking Zeitwerk in #8863.