Update snapshot deploy to use new maven infrastructure#8868
Merged
Conversation
This avoids attempting to sign the snapshots, which can't easily be done from GHA.
Not sure why it proceeds in the release profile but this seems to be necessary for snapshots.
jruby-complete was previously bundling jruby-core sources to fulfull the requirement of maven central for sources to be provided, but that artifact only published a dummy source jar. In this snapshot work, for some reason that jruby-core source jar is no longer created, but then jruby-complete has no sources to copy. This change modifies jruby-complete to use jruby-base sources, which provides the sources for JRuby itself as it should. I am unclear on why this worked in the past, but it could be something related to the old parent pom we no longer use. What I have here works, but I seek a better explanation for why it broke.
headius
force-pushed
the
new_maven_snapshots
branch
from
5c281bb to
9b6145d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a number of changes here to support deploying snapshots locally or automatically on GHA:
snapshotsprofile and using that profile to create snapshots instead ofrelease.This appears to be working to deploy snapshots now locally and on GHA, but I have some doubts:
jruby-9.4branch. Why then did it fail after merging those changes to master (10)?