Skip to content

Tweaks to further improve startup speed and memory use #8831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 2 commits into from
Jul 15, 2025
Merged

Tweaks to further improve startup speed and memory use #8831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe49713
Don't double-read the input stream
headius May 6, 2025
90849ce
Use Java 9 readAllBytes
headius May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/runtime/load/ExternalScript.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void load(Ruby runtime, boolean wrap) {
} else {
name = CompiledScriptLoader.getFilenameFromPathAndName(resource.getPath(), name, resource.isAbsolute());

runtime.loadFile(name, new LoadServiceResourceInputStream(in), wrap);
runtime.loadFile(name, in, wrap);
}
} catch (IOException e) {
throw runtime.newIOErrorFromException(e);
Expand Down
14 changes: 3 additions & 11 deletions core/src/main/java/org/jruby/runtime/load/LoadServiceResourceInputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,9 @@ public byte[] getBytes() {
return buf;
}

private static final int READ_CHUNK_SIZE = 16384;

private void bufferEntireStream(InputStream stream) throws IOException {
byte[] chunk = new byte[READ_CHUNK_SIZE];
int bytesRead;
while ((bytesRead = stream.read(chunk)) != -1) {
byte[] newbuf = new byte[buf.length + bytesRead];
System.arraycopy(buf, 0, newbuf, 0, buf.length);
System.arraycopy(chunk, 0, newbuf, buf.length, bytesRead);
buf = newbuf;
count = buf.length;
}
byte[] all = stream.readAllBytes();
buf = all;
count = all.length;
}
}