I am a bit wary of upgrading RSpec to 2.14.x, which I believe deprecated a whole lot of stuff, causing a lot of noise. 2.13.x should be OK. If the user wants 2.14.x, they should be able to do so.

@BanzaiMan I think its used only for JRuby development and build procedure. Users may use whatever version they want in their apps. Also i wanted to have clean travis run with Rspec 2.14.x as i have not run all specs locally. So that we will really know the impact of this change. But right now travis is failing for everything.

That's true. We do not ship rspec as part of our dist anymore. I don't
have a huge issue with upgrading since if we are internally using
deprecated stuff it would be better to know sooner than later, but is there
any other benefits to upgrading beyond staying current?

On Mon, Jul 15, 2013 at 2:32 AM, प्रथमेश notifications@github.com wrote:

@BanzaiMan https://github.com/BanzaiMan I think its used only for JRuby
development and build procedure. Users may use whatever version they want
in their apps. Also i wanted to have clean travis run with Rspec 2.14.x as
i have not run all specs locally. So that we will really know the impact of
this change. But right now travis is failing for everything.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/883#issuecomment-20955183
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

RSpec 2.14 will be last release in 2.x series so we will be better prepared for RSpec 3. Thats the main reason.

Ok so I am ok with internally updating rspec since only we use it for
development time but the JSON change should be decided separately since
that is a forward facing gem (isn't it)? Anyone have an opinion on this?

On Mon, Jul 15, 2013 at 10:49 AM, प्रथमेश notifications@github.com wrote:

RSpec 2.14 will be last release in 2.x series so we will be better
prepared for RSpec 3. Thats the main reason.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/883#issuecomment-20978943
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

@enebo If the specs pass, I'm fine with it. Either way, I think we should split this PR into two and discuss separately.

@BanzaiMan @enebo Updated this PR to only update RSpec