9-digit rational needs to be multiplied by 9 digits#8803
Closed
enebo wants to merge 1 commit intojruby:masterfrom
Closed
9-digit rational needs to be multiplied by 9 digits#8803enebo wants to merge 1 commit intojruby:masterfrom
enebo wants to merge 1 commit intojruby:masterfrom
Conversation
Member
Author
|
There is a lot of logic missing in Time involving rational normalization. There is not a simple fix. Closing until I understand this better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #8788 but there is zero coverage and I can see the rational processed here can get made in various ways. My confidence is not super high but what I had before was clearly wrong. I am going to try and make some more tests.