Java version detection improvements#8753
Merged
headius merged 9 commits intojruby:masterfrom Apr 8, 2025
Merged
Conversation
We want to be able to use this script with older versions of JRuby that will have different minimum Java versions, so use a new file bin/.java-version as the minimum.
Many Java 1.8 builds do not include a `release` file, and other post-1.8 JDKs may not include the file (though we have not found any recently). Since the release file started to show up around Java 9 timeframe, this change assumes if it is not present, we are probably on Java 8. This is the second change necessary to make the new launcher script work on older JRuby versions that still support Java 8.
headius
changed the title
Member
Author
|
A few additional tweaks:
|
Member
Author
|
This is being tested with 9.4 in #8754 and is green with the latest set of changes. |
mrnoname1000
reviewed
Apr 8, 2025
mrnoname1000
reviewed
Apr 8, 2025
headius
force-pushed
the
minimum_java_for_launcher
branch
from
0595969 to
3d6e75c
Compare
Contributor
|
LGTM |
headius
added a commit
to jruby/jruby-launcher
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to be able to use this script with older versions of JRuby that will have different minimum Java versions, so use a new file bin/.java-version as the minimum.
Once this is approved we should be able to backport the script to JRuby 9.4 and know that it won't cause problems if it is copied or backported manually to versions older than that.