Update URI gem to 1.0.3 in JRuby 10#8751
Merged
headius merged 3 commits intojruby:masterfrom Apr 8, 2025
Merged
Conversation
kaisecheng
reviewed
Apr 7, 2025
| <include>gems/tsort-0.2.0*/**/*</include> | ||
| <include>gems/un-0.3.0*/**/*</include> | ||
| <include>gems/uri-1.0.2*/**/*</include> | ||
| <include>gems/uri-1.0.3*/**/*</include> |
There was a problem hiding this comment.
The header of pom.xml says "DO NOT MODIFY - GENERATED CODE". I think this file is not supposed to update.
Contributor
Author
There was a problem hiding this comment.
Updated executing a build, run ./mvnw
Member
|
Actually we do commit changes to that file but it should not be edited by hand. It gets regenerated by the build, so you make a change to the pom.rb, run one build, and commit both files. Thanks for the PR! A few things for you to consider:
|
Contributor
Author
andsel
changed the title
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.