Conversation
A static VarHandle should inline better than AtomicInteger, which requires calling through potentially megamorphic calls for several atomic operations. This also avoids allocating AtomicObject.
Showed up in a profile and there were a few tweaks that might help performance in micro ways.
This also eliminates two invalidator objects from the runtime.
Most runs of JRuby will never use coverage data, so allocating this eagerly is wasted time and memory most of the time. This patch makes Ruby.coverageData allocation lazy, only if directly requested, and adds a no-allocation way to test if coverage has been enabled. This may improve performance of execution paths that previously acquired the field, invoked "isCoverageEnabled", read another field, and compared that result with a constant. these paths are potentially very hot since coverage events typically happen on every line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These can be punted to 10.x if they get too involved for release in 10.0.