Remove this warning to match standard set.rb#8733
Merged
headius merged 1 commit intojruby:jruby-9.4from Mar 31, 2025
Merged
Conversation
The standard set library does not warn along any path if an unused block is passed to initialize. We should do the same until the maintainers of the set gem decide that the warning should be added. Fixes jruby#8728 See ruby/set#41 for a report about the "missing" warning.
headius
force-pushed
the
set_init_block_warn
branch
from
24eb927 to
628d106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard set library does not warn along any path if an unused block is passed to initialize. We should do the same until the maintainers of the set gem decide that the warning should be added.
Fixes #8728
See ruby/set#41 for a report about the "missing" warning.