Conversation
headius
left a comment
There was a problem hiding this comment.
I think we need to detect whether we found a JAVA_HOME a different way that works without the release file; perhaps $JAVA_HOME/bin/java?
8ecf4fd to
7e3a1b1
Compare
|
Added some code to parse |
7e3a1b1 to
7753118
Compare
The problem with this is we find JAVA_HOME by trimming |
7753118 to
89dbb3b
Compare
|
@mrnoname1000 Please re-review this... it's been sitting for a few months and I want to make sure it's still valid. |
|
Weirdly enough the last commit to the launcher in master was less than an hour before the first one in this branch, so no conflicts and everything still looks valid |
|
@mrnoname1000 Thanks, merged! |
Launcher: Defensive fixes
Added some checks to the launcher to handle missing
HOME,JAVA_HOME, or argument to-{C,e,I,S}Fixes #8747