Apply Java version-specific flags in launcher script#8718
Merged
headius merged 1 commit intojruby:masterfrom Mar 26, 2025
Merged
Apply Java version-specific flags in launcher script#8718headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
headius
force-pushed
the
unsafe_native_flags
branch
from
4000ee9 to
06f1ecb
Compare
Contributor
mrnoname1000
left a comment
mrnoname1000
left a comment
There was a problem hiding this comment.
I would avoid nesting so many conditionals, it's much more verbose and comparisons are cheap. We could use some other structure if we wanted to consolidate, but no matter what every check is going to happen on >=23 or <13 depending on which we check first
Member
Author
|
Perhaps it's just better to drop that commit then. It's not critical, and I don't like it as much as I thought. Your point about doing all the checks anyway depending on how we search also makes sense. |
headius
force-pushed
the
unsafe_native_flags
branch
from
06f1ecb to
c0bfde9
Compare
These flags are only available at certain levels of JDK, so we add version-specific logic to the launcher. See jruby#8696 This will fix that issue for 9.4 once we backport the script. It fixes it for JRuby 10 right away.
headius
force-pushed
the
unsafe_native_flags
branch
from
c0bfde9 to
8ff65f4
Compare
mrnoname1000
approved these changes
Mar 26, 2025
Contributor
mrnoname1000
left a comment
mrnoname1000
left a comment
There was a problem hiding this comment.
Aside from that duplicate comment looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds flags for native access and unsafe memory functions and cleans up some of the launcher logic around Java version detection.
Relates to #8696.