Less eager coderange when converting Java String#8711
Merged
headius merged 1 commit intojruby:masterfrom Mar 24, 2025
Merged
Conversation
By going to VALID, we force all Java strings produced by this function to do full Unicode validation when they are manipulated or written to another string. This was the root cause of jruby#8710, when an already-broken StringIO saw an incoming VALID string and followed full MBC verification logic. This patch assumes that if the resulting byte[] string has the same number of bytes as the original string had chars, and the destination encoding is 7-bit ASCII compatible, then the code range can be 7-BIT, avoiding extra encoding logic for such strings. This feels like a bit of a hack; CRuby fails the cases in jruby#8710 exactly like JRuby if an MBC element is in the backtrace, meaning that it was just "lucky" that the test case from rake produced only 7-bit backtrace elements. There's more discussion needed here, because I'm not sure this test is actually testing anything reliable.
Member
Author
|
@enebo I'm going to merge this to get a new 10 build out there, but please review and discuss with me when you get a chance. |
This was referenced Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By going to VALID, we force all Java strings produced by this function to do full Unicode validation when they are manipulated or written to another string. This was the root cause of #8710, when an already-broken StringIO saw an incoming VALID string and followed full MBC verification logic.
This patch assumes that if the resulting byte[] string has the same number of bytes as the original string had chars, and the destination encoding is 7-bit ASCII compatible, then the code range can be 7-BIT, avoiding extra encoding logic for such strings.
This feels like a bit of a hack; CRuby fails the cases in #8710 exactly like JRuby if an MBC element is in the backtrace, meaning that it was just "lucky" that the test case from rake produced only 7-bit backtrace elements. There's more discussion needed here, because I'm not sure this test is actually testing anything reliable.