Customize checkstyle to make it more lenient.#869
Merged
mkristian merged 3 commits intojruby:masterfrom Jul 10, 2013
jendave:checkstyle
Merged
Customize checkstyle to make it more lenient.#869mkristian merged 3 commits intojruby:masterfrom jendave:checkstyle
mkristian merged 3 commits intojruby:masterfrom
jendave:checkstyle
Conversation
Contributor
Author
|
Hi kristian. Can you look at this? Thanks. |
Member
|
could you remove the .gitignore commit since I do have no overview of its impact. the iml files could go into your global gitignore. the lib/jruby-original.jar it feels it should not pop up. or are all those files generated by the mvn site execution ? |
Contributor
Author
|
Thanks. I'll fix the commit. |
This reverts commit 09dc1dd.
Contributor
Author
|
I have reverted the change on .gitignore. |
mkristian
added a commit
that referenced
this pull request
Jul 10, 2013
Customize checkstyle to make it more lenient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there are still many checkstyle violations, most of them are formatting issues which I can handle fairly quickly.