Conversation
Member
headius
commented
Mar 6, 2025
headius
commented
- Type the cache as containing FString.
- Make FStringEqual wrapper closeable for try-with-resources.
- Clean up FString construction.
- Allow incoming FString to become the cached FString if it wins.
- Allow going straight to cache with ByteList rather than via intermediate RubyString.
- Cache an fstring for each symbol.
headius
force-pushed
the
cleanup_fstring
branch
2 times, most recently
from
6b49a10 to
178d280
Compare
* Type the cache as containing FString. * Make FStringEqual wrapper closeable for try-with-resources. * Clean up FString construction. * Allow incoming FString to become the cached FString if it wins. * Allow going straight to cache with ByteList rather than via intermediate RubyString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.