fix a regression in KDDI transcoding#8671
Merged
headius merged 1 commit intojruby:jruby-9.4from Mar 7, 2025
Merged
Conversation
Member
|
Some commits snuck into master but not jruby-9.4 so I rebased the latter. Shouldn't affect this if you rebase the PR. Once we have a repaired jcodings I will merge that to 9.4 and you can merge or rebase onto the PR. |
Merged
ahorek
force-pushed
the
enable_encoding_tests
branch
from
e0cce8e to
ce48d84
Compare
ahorek
changed the title
Member
|
@ahorek We're close! Looks like two failures here after the updated versions of jcodings and joni are available. I get the same failures locally without the jcodings/joni updates, so it's not a regression from anything you did. I'm going to go ahead and merge this and exclude from the jruby-9.4 branch. If you feel so inclined to keep digging into those last two, go for it! |
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 7, 2025
These are probably not recent regressions, but tagging them for now to get master back to green after recent jcodings updates. Relates to jruby#8671
headius
added a commit
that referenced
this pull request
Mar 7, 2025
These are probably not recent regressions, but tagging them for now to get master back to green after recent jcodings updates. Relates to #8671
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes jruby/jcodings#64
depends on jruby/jcodings#67