Fixes to get stringio tests and specs green#8643
Merged
headius merged 3 commits intojruby:masterfrom Feb 20, 2025
Merged
Conversation
The stringio library depends on being able to pass an encoding only as the first argument to rb_enc_check, which causes the downstream enc_compatible_latter to reject incompatible encodings regardless of the first string being blank. Part of fixes to pass stringio tests in ruby/stringio#116.
Member
Author
|
These will need ruby/stringio#116 to be merged and released before being green and removing spec tags and test excludes. |
headius
force-pushed
the
stringio_fixes
branch
from
ec2d7f7 to
25320ad
Compare
headius
added a commit
to headius/stringio
that referenced
this pull request
Feb 20, 2025
This method is added to JRuby in 9.4.13.0 and avoids the overhead of creating a fake CodeRangeable. See jruby/jruby#8643
headius
added a commit
to headius/stringio
that referenced
this pull request
Feb 20, 2025
This method is added to JRuby in 9.4.13.0 and avoids the overhead of creating a fake CodeRangeable. See jruby/jruby#8643
headius
added a commit
to ruby/stringio
that referenced
this pull request
Feb 20, 2025
This method is added to JRuby in 9.4.13.0 and avoids the overhead of creating a fake CodeRangeable. See jruby/jruby#8643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After working on getting the CRuby stringio tests green in ruby/stringio#116 I turned my attention to stringio specs. These fixes are intended to get the specs green as well.