Remove raw array methods and helpers with fillnil changed#8639
Merged
enebo merged 2 commits intojruby:10-devfrom Feb 19, 2025
Merged
Remove raw array methods and helpers with fillnil changed#8639enebo merged 2 commits intojruby:10-devfrom
enebo merged 2 commits intojruby:10-devfrom
Conversation
Now that we are not filling nils to capacity of array we do not need these methods at all and can go back to newArray(context, length).
newArray has bugged me for the length versions because while it makes a new Array it is empty and the length value is not obvious in what it provides. At least, this is my take on what a new user would ponder. alloc shows intent more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are not filling nils to capacity of array we do not need these methods at all and can go back to newArray(context, length).