Add --cache flag to regenerate AppCDS#8625
Merged
headius merged 1 commit intojruby:masterfrom Feb 12, 2025
Merged
Conversation
This experimental flag can be passed to JRuby, with or without Ruby arguments, to regenerate the AppCDS archive jruby.jsa under the lib dir of the current JRuby install. This file is automatically used if present by the launcher to improve startup time.
Member
Author
|
Relates to #8610. |
Comment on lines
+637
to
+639
| if $regenerate_jsa_file & [ \'"$ruby_args"\' = "' '" ]; then | ||
| assign ruby_args '-e' '1' | ||
| fi |
Contributor
There was a problem hiding this comment.
That looks like a pretty fragile way to check that the ruby_args array is empty, I would prefer to either parse it and check $# or we could get clever and match against *[![:space:]]*. Also quotes are unnecessary on line 638
Contributor
There was a problem hiding this comment.
Oh and there's a bug here, & forks off a subshell so if [ "$ruby_args" = " " ] then this will always execute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This experimental flag can be passed to JRuby, with or without Ruby arguments, to regenerate the AppCDS archive jruby.jsa under the lib dir of the current JRuby install. This file is automatically used if present by the launcher to improve startup time.