Eiminate last uses of UnsafeHolder#8616
Merged
headius merged 2 commits intojruby:10-devfrom Feb 9, 2025
Merged
Conversation
This eliminates both the Unsafe code and the Atomic* fallback logic, plus improves atomicity along a couple paths.
headius
force-pushed
the
nbhml_varhandles
branch
from
da69d17 to
f8b76f0
Compare
Member
Author
|
@kares You did a conversion long ago to support NonBlockingHashMapLong without Unsafe, could you review this to make sure I removed everything correctly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the last usage of UnsafeHolder and removes it.
This also migrates NonBlockingHashMapLong to use VarHandle instead of either Unsafe or Atomic* logic. This change also restores atomicity to all logic.