Fixes #8577. kwargs checking: Use bits instead of index#8599
Merged
enebo merged 2 commits intojruby:masterfrom Feb 11, 2025
Merged
Fixes #8577. kwargs checking: Use bits instead of index#8599enebo merged 2 commits intojruby:masterfrom
enebo merged 2 commits intojruby:masterfrom
Conversation
…better method in retrospect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyword index of first keyword encountered in parameter lists is problematic because other variables during parsing can still be encountered (see #8577 for an example).
This fix is a shorter-term fix where we maintain a bitlist to indicate which parameters are keywords. This removes the need for all keywords to be definedcd at the end of the scope.
The longer term fix is to fully describe the parameters which can be introspected by the callsite. This goes way beyond this fix as it outlines how we can easily map known keyword values to keyword parameters in the method and eliminate storing the keywords in a hash (in this case we can pass them as positional parameters). This is a larger work item and is too much for us in the short term.