Conversation
This fix is ugly but in recv_keyword we will notice that it is not really a keyword but an element of a rest arg. In that case we will dup the kwarg into a normal hash argument. The ugly part is this is handled while processing kwargs but if I went to figure out how this worked I would think the logic would be in recv_rest_arg. Unfortunately, we no longer have the info available by that point (and honestly it would be painful to propagate to a later instruction).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is ugly but in recv_keyword we will notice that it is not really a keyword but an element of a rest arg. In that case we will dup the kwarg into a normal hash argument.
The ugly part is this is handled while processing kwargs but if I went to figure out how this worked I would think the logic would be in recv_rest_arg. Unfortunately, we no longer have the info available by that point (and honestly it would be painful to propagate to a later instruction).