Fix arity specs for blocks in language#8554
Merged
enebo merged 2 commits intojruby:10-devfrom Jan 5, 2025
Merged
Conversation
The basic problem was we were not matching MRI in returning 1 for `|a, **k|` and instead returning -2. There was some other issue which occurred where a weird signature is not being marked as rest and messing up arity for Proc#arity. I plan on taking a stab at it in next commit but this fix is more important than that so this will land even if I cannot figure that out.
I had a FIXME about this from another fix for arities and I just followed MRIs lead here and did it the same way. I originally had not because the arity was wrong for execution but right for #arity. This turned out to be because 3.4 changed how procs spread in the presence of kwargs (previous commit fixed that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic problem was we were not matching MRI in returning 1 for
|a, **k|and instead returning -2. There was some other issue which occurred where a weird signature is not being marked as rest and messing up arity for Proc#arity. I plan on taking a stab at it in next commit but this fix is more important than that so this will land even if I cannot figure that out.