Merged
Conversation
…it used to be bound Object#type which is long gone
… be set. Don't double get default separator on join
There are still existing users of old warnin apis but those involve file/line number and I am unsure how we should handle that. Last vestige of core/primal initialization handled with topSelf construction of methods/aliases moved after first thread context initialization.
…occur after TC is made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn API made: warn and warnDeprecated so far.
I also audited our existing warnings and removed methods which no longer exists in 3.4. This could possible be an incompatibility for an native extension if they called these methods but we need to cull them and not existing is a pretty good justification (note: we can always readd them. I made them each an individual commit in case this happens).