Conversation
… help method discardTopValue()); Addition of some @OverRide
…nstead of long method calls
Conflicts: src/org/jruby/ir/IRScope.java
|
I think verifybytecode looks like a good change to me but you might want to isolate current JIT code changes to it's own PR and perhaps only make the verifyByteCode() method as the sole PR. @headius can decide whether he likes the change since he primarily works in that package space. The Ruby try { inputstream.close() } bulletproofing can also be it's own PR. We generally don't bulletproof code against things which should not happen (although we should have had an assert there) but your pattern is quite common and someone will likely eventually submit that change again. You can make a massive @OverRide PR and I will apply that so long as it has no other changes. We have not been up to date with that in a long time. Make sure you @Oveeride with respect to Java 6 and not Java 7 though. |
|
Yeah re Java 6 versus Java 7; I believe Java 6 will error if you @OverRide an interface method...so make sure any change you make works on 6 and 7. |
Refactoring on: