Conversation
Fixes test/mri/test_io.rb:test_copy_stream_broken_src_read_eof
* Calculate growth size in an initial loop. * Add equivalent to str_ensure_available_capa for growing strings. * Refactor for arity-split (just 0 and 1 arg forms added).
If a thread is killed and then quickly interrupted in another way, it may end up polling for that other event and stop aborting from the kill. This ensures that once aborted a thread can never stop aborting by picking up a new interrupt event. This broke the new test server in test/mri/net/http/utils.rb when it killed the server and then closed the socket; while aborting the closed socket could trigger additional exceptions, stopping the abort. This ensures it will be seen at the next poll and resumed.
In CRuby, a thread remains internally in "run" state while in the process of being killed, but a killed bit is set for other status-sensitive functions to check. This patch aligns behavior with CRuby.
This is a temporary move until we can follow CRuby and implement a native version of this function. See jruby#8476
"aborting" is only presented as status when a thread has been actively killed, which is implemented by a separate flag. The thread remains internally in RUN status, as in CRuby.
Copied from my PR to fix this double-interrupt race. See ruby/net-http#197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get them running and fix some stuff.